Default settings (and minor styling thing)
I would like to see the following changes:
-
Upon running a default installation of PageSync, I get the following message: PHP Notice: Undefined index: filePath in /data/www/dev2-02.wikibase.nl/public_html/extensions/PageSync/WSpsHooks.php on line 195
. Presumably this is because$wgPageSync['filePath']
is not set. I would expect this setting to receive a default value (for example: '$IP' by default). It should be mentioned that my PageSync maintenance script execution did work (I used the--install-shared-file
) option. -
On a subsequent running of the script, I got the following message: PHP Notice: Undefined index: exportPath in /data/www/dev2-02.wikibase.nl/public_html/extensions/PageSync/WSpsHooks.php on line 1676
. Similar to the above, I would expect PageSync to run without having to explicitly set these. Default values would be nice to have here, as well. -
There is no newline character when the script reports its results. This doesn't look great, since it reports something like this: Done! 58 succeeded, 0 skipped.development@true02:/data/www/dev2-02.wikibase.nl/public_html$
Please add a newline character to the end of this result.