Merge branch 'remove-redundant-security-checks' into 'master'

Remove redundant security check from special pages

Closes #1

See merge request extensions/wsspaces!3

extension.json

 {
   "name": "WSSpaces",
-  "version": "2.1.0",
+  "version": "2.2.0",
   "namemsg": "wss-extensionname",
   "url": "https://wikibase-solutions.com",
   "type": "csp",

src/Special/SpecialActiveSpaces.php

@@ -56,13 +56,6 @@ class SpecialActiveSpaces extends SpecialPage {
 		return $this->msg( 'wss-active-spaces-header' )->plain();
 	}
 
-	/**
-	 * @inheritDoc
-	 */
-	public function getLoginSecurityLevel() {
-		return 'ws-manage-namespaces';
-	}
-
 	/**
 	 * The main method that gets invoked upon successfully loading the special page, after preExecuteChecks have
 	 * been performed.

src/Special/SpecialAddSpace.php

@@ -48,13 +48,6 @@ class SpecialAddSpace extends SpecialPage {
 		return $this->msg( 'wss-add-space-header' )->plain();
 	}
 
-	/**
-	 * @inheritDoc
-	 */
-	public function getLoginSecurityLevel() {
-		return 'ws-create-namespaces';
-	}
-
 	/**
 	 * @inheritDoc
 	 * @throws \MWException

src/Special/SpecialArchivedSpaces.php

@@ -56,13 +56,6 @@ class SpecialArchivedSpaces extends SpecialPage {
 		return $this->msg( 'wss-archived-spaces-header' )->plain();
 	}
 
-	/**
-	 * @inheritDoc
-	 */
-	public function getLoginSecurityLevel() {
-		return 'ws-manage-namespaces';
-	}
-
 	/**
 	 * @inheritDoc
 	 * @throws MWException

src/SpecialPage.php

@@ -15,16 +15,6 @@ abstract class SpecialPage extends \SpecialPage {
 		$this->setHeaders();
 		$this->checkPermissions();
 
-		$security_level = $this->getLoginSecurityLevel();
-
-		if ( $security_level ) {
-			$proceed = $this->checkLoginSecurityLevel( $security_level );
-
-			if ( !$proceed ) {
-				return;
-			}
-		}
-
 		if ( $this->preExecute() === false ) {
 			return;
 		}